Firo-QT cosmetic fixes

[firstcryptoman]

1. Dropdown Sizing in Comboboxes Cosmetic Error with Firo-QT qcomboboxs #1416

Fixed oversized dropdowns that covered other UI elements. Adjustments:

Made combobox indicators transparent.
Set a max-height of 25px for dropdown items.

2. Top Bar Text Visibility on Fedora Top bar not visibile in firo-qt on Fedora #1354

Improved the top bar's text visibility by explicitly setting the text color to black, ensuring it does not rely on the OS's default colors, which caused readability issues.

3.Backup Wallet Menu Font Readability with Dark UI Theme #1422

Enhanced the readability of the folder's fonts in the "Backup Wallet" menu when using a dark UI theme.

Summary by CodeRabbit

• Style
  • Updated the menu bar items to have black text color for improved readability.
  • Enhanced dropdown elements' styles with transparent indicators and adjusted maximum height for better user interface consistency.

[coderabbitai]

Walkthrough

The update introduces visual enhancements to the application's user interface. It focuses on improving the aesthetics and usability of various elements. Menu bar items now boast a sleek black text color for better readability. The styling tweaks in the CSS file refine the appearance of combo boxes, ensuring a polished and consistent UI experience.

Changes

File(s)	Summary
src/qt/bitcoingui.cpp	Set menu bar items' text color to black.
src/qt/res/css/firo.css	Enhanced styling in firo.css: - Made QComboBox::indicator background transparent. - Added max-height: 25px to QComboBox::item.

🐇✨
In the realm of code, where changes abound,
A rabbit hopped in, improvements found.
Black text, transparent cues, all around,
A cleaner UI, in beauty, unbound.
Hop, hop, hurray, for the changes profound!
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 17aab98 and f78855e.

Files selected for processing (2)

• src/qt/bitcoingui.cpp (1 hunks)
• src/qt/res/css/firo.css (2 hunks)

Files skipped from review due to trivial changes (1)

• src/qt/bitcoingui.cpp

Additional comments not posted (2)

src/qt/res/css/firo.css (2)

354-354: The change to make the QComboBox::indicator background color transparent is a good approach to reduce visual clutter as mentioned in the PR objectives. This should help with the dropdown sizing issue without affecting the functionality of the comboboxes.

---

376-376: Setting a max-height: 25px for QComboBox::item is an effective way to ensure dropdown items do not cover other parts of the interface excessively. This change directly addresses the issue of oversized dropdowns in comboboxes. However, it's important to verify this change does not negatively impact the visibility or usability of the dropdown items, especially if they contain longer text strings.

[erciccione]

I confirm #1354 is resolved by this pr.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f78855e and a1e61d4.

Files selected for processing (1)

• src/qt/res/css/firo.css (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/qt/res/css/firo.css