Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs + readme #8

Merged
merged 4 commits into from
Dec 9, 2024
Merged

update docs + readme #8

merged 4 commits into from
Dec 9, 2024

Conversation

caglacelik
Copy link
Contributor

  • Update README
  • Update docs

@caglacelik caglacelik marked this pull request as ready for review December 5, 2024 10:52
@caglacelik caglacelik requested a review from erhant December 5, 2024 10:52
erhant
erhant reviewed Dec 9, 2024
View reviewed changes
README.md
```sh
make test-inv
forge test --rpc-url <RPC_URL>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add comment here to indicate that --force is not required

erhant
erhant approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@erhant erhant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erhant erhant merged commit 6a4c427 into master Dec 9, 2024
2 checks passed
@erhant erhant deleted the caglacelik/pr-fixes branch December 9, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erhant erhant erhant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caglacelik @erhant