Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1: Necessary Plugin Improvements #2

Merged
merged 19 commits into from
Jan 21, 2024
Merged

1: Necessary Plugin Improvements #2

merged 19 commits into from
Jan 21, 2024

Conversation

ppaulweber
Copy link
Member

@ppaulweber ppaulweber commented Jan 21, 2024 •
edited
Loading

This PR introduces the following changes:

  • provides clear separation of plugin.Datasource internal configuration structure and the provided JSON data model from the frontend side
  • removed additional and basic query check of valid syntax elements and completely rely on the IAM model of the SurrealDB instance user access rights (recommendation: VIEWER ROLE)
  • removes debugging code on frontend and backend side of the plugin
  • provides default dashboard to demonstrate different query functionalities of the data source plugin
  • provides correct and minimal query-based JSON data payload to be send to the backend data source plugin
  • fixes Initial Review and Publishing Process #1

@ppaulweber
Configuration: provided 'check' target for compatibility via levitate…
bd2f9dd 
… tooling
@ppaulweber
Deployment: updated 'local' environment to support latest SurrealDB v…
2266bc4 
…ersion
@ppaulweber
Types: clean-up of Query interface
fa2b27a
@ppaulweber
Datasource: clean-up of frontend by removing yet not needed 'getResou…
82f6a43 
…rce' requests
@ppaulweber
Datasource: fixed missing query hiding, explicit configuration handli…
ca93ec6 
…ng, and clean-up of not used Resource request handling
@ppaulweber
Provisioning: provided dedicated Grafana user with viewer role
44d8071
@ppaulweber
Deployment: updated 'local' deployment with dedicated dashboard setup…
3e95809 
… and reduced SurrealDB requirements
@ppaulweber
Provisioning: updated example datasource integration
95467f9
@ppaulweber
Provisioning: provided example dashbaord for timeseries visualization
ab3265a
@ppaulweber
ConfigEditor: updated default values/suggestions and added optional s…
80f4d39 
…cope configuration option
@ppaulweber
QueryEditor: updated set of metric rate functions
0355b0b
@ppaulweber
Plugin: updated default query setup
ade6497
@ppaulweber
Datasource: updated configuration and rewrite of the metric and rate …
3a03c83 
…logic
@ppaulweber
Plugin: fixed query JSON data protocol
6ab615c
@ppaulweber
Datasource: fixed default value handling
2645234
@ppaulweber
Datasource: fixed deduction of standard interval parameter
1230167
@ppaulweber
Provisioning: updated default dashboard setup
a2e642b
@ppaulweber
QueryEditor: fixed mode handling
7bb2046
@ppaulweber
Test: adopted the E2E case to only open home since the redirect goes …
abc7f20 
…to the default dashboard
@ppaulweber ppaulweber merged commit 1d3af4c into master Jan 21, 2024
2 checks passed
@ppaulweber ppaulweber deleted the feature/1_initial_review branch January 21, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial Review and Publishing Process
1 participant
@ppaulweber