Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove charSize. Always use utf8. #63

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

matheus23
Copy link
Member

No description provided.

@matheus23
Copy link
Member Author

Closes #60

(but is still a draft - things to figure out, mainly how breaking this will be)

@icidasset
Copy link
Contributor

I've been looking at this a bit myself.
Why would we want plain strings at all for this library? 🤔
Why not always use Uint8Arrays or encoded strings (eg. base64)?

@matheus23
Copy link
Member Author

Aside: status of this PR is that it breaks some stuff in webnative and I didn't yet do the work of figuring it out yet.

Yeah I agree with that mostly. I think in some cases you want to be able to encrypt some user input maybe?

Something needs to change though. Encoding seems messy at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants