Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back MongoDB id property to API response #309

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Feb 26, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: #308

What is the new behavior?

  • Fix failed end-to-end testing
  • Bring back the generated MongoDB id to the response. For example:

GET /villages/1101012001

{
  "statusCode": 200,
  "message": "OK",
  "data": {
    "id": "65dc3d954a0c65806162bd14",
    "code": "1101012001",
    "districtCode": "110101",
    "name": "Keude Bakongan",
    "parent": {
      "district": {
        "id": "65dc3d884a0c658061625e44",
        "code": "110101",
        "name": "Bakongan",
        "regencyCode": "1101"
      },
      "regency": {
        "id": "65dc3d874a0c658061625c42",
        "code": "1101",
        "name": "KABUPATEN ACEH SELATAN",
        "provinceCode": "11"
      },
      "province": {
        "id": "65dc3d864a0c658061625c1c",
        "code": "11",
        "name": "ACEH"
      }
    }
  }
}

Other information

Will resolve #308

@fityannugroho fityannugroho added the bug Something isn't working label Feb 26, 2024
@fityannugroho fityannugroho linked an issue Feb 26, 2024 that may be closed by this pull request
@fityannugroho fityannugroho merged commit 678c88e into main Feb 26, 2024
5 checks passed
@fityannugroho fityannugroho deleted the fix/issue-308 branch February 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back MongoDB id property to API response
1 participant