Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migration to tauri v2 #50

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

hashedone
Copy link

@hashedone hashedone commented Feb 4, 2025

Migration to tauri v2 with minimal cleanup.
.gitignore files collapsed into single one - some building step likes do remove the whole dist/ and dist/.gitignore happens to get changes to stage.
Mostly done by automatical migrations, but some manual alignments had to be done. get_app_data_dir now need to be called on PathResolver - to avoid passing it everywhere, I simply built the path once and stored it as a tauri state (the Db type). Later step could be possibly to maintain the connection to db (however I don't think that makes any difference using sqlite).
The PR only seems overwhelming - vast majority of it is Cargo.lock.

@hashedone
Copy link
Author

I see the pipeline failing on clippy and test, but it looks like a CI config issue. I take a look what's going on there.

@hashedone
Copy link
Author

The only issue failing now is due to some private key issue (looks like key format changed?). The only hint I found is tauri-apps/tauri-action#658 (comment) (and whats interesting the issue is very recent).
I am wondering - is the updater even needed at this point? It is obviously not working - https://fitztrev.github.io/lichess-tauri/version.json is pointing to not existing version. It is also not invoked anywhere, only artifacts are generated. It could be either removed and added from the scratch, or at least keys could be easily regenerated with the new cli for now as obviously noone is using updater feature atm.

@fitztrev
Copy link
Owner

fitztrev commented Feb 5, 2025

Sounds good, yes you can disable the updater and signing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants