[Feature] Add tag and task_tag variable configs
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-jamie
requested changes
Feb 14, 2025
DECISIONLOG.md
Outdated
| @@ -0,0 +1,13 @@ | |||
| # Decision Log | |||
There was a problem hiding this comment.
we should remove the decision log now that we're just using the variables instead of does_table_exist()
Done! |
fivetran-catfritz
approved these changes
Feb 18, 2025
CHANGELOG.md
Outdated
| @@ -1,7 +1,16 @@ | |||
| # dbt_asana_source version.version | |||
| # dbt_asana_source v0.8.1 | |||
| This release introduces the following updates. | |||
There was a problem hiding this comment.
Suggested change
| This release introduces the following updates. | |
| This release introduces the following updates: |
CHANGELOG.md
Outdated
|
|
||
| ## Documentation | ||
| - Corrected references to connectors and connections in the README. ([#36](https://github.com/fivetran/dbt_asana_source/pull/36)) | ||
| - Updated `src_asana.yml` with the above variable configurations to the source tables `tag` and `task_tag`. ([#37](https://github.com/fivetran/dbt_asana_source/pull/37)) |
There was a problem hiding this comment.
I would put this in Under the hood since it is functional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: See issue #36 in
dbt_asanaThis PR will result in the following new package version: v0.9.0
We are introducing variable configuration (entire models could be disabled if selected), so a breaking change seems like the best approach here.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Breaking Changes
asana__using_tagsandasana__using_task_tagsto disable thestg_asana__tagandstg_asana__task_tagmodels respectively. This allows the downstream models to run even if the respective sourcetagandtask_tagtables don't exist. For more information on how to configure refer to the README.Documentation
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Tested the new variable configurations and confirmed the above models disabled when the variables were set to false.
If you had to summarize this PR in an emoji, which would it be?
🪄