Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add locations passthrough column functionality to transaction details #125

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Jul 22, 2024

PR Overview

This PR will address the following Issue/Feature: [#123]

This PR will result in the following new package version:

A column is being added to netsuite2__transaction_details.

Regardless, this is likely to be folded into a larger release branch with additional updates.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes 🚨

  • Added the column location_id to the netsuite2__transaction_details model. To bring this column in, a --full-refresh after upgrading is required. (PR #125)

Features

Under the Hood

  • Added a consistency test for the netsuite2__transaction_details model. (PR #125)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Able to successfully pass through location columns.

Simple consistency test added on transaction details, run on devprod. We do an except(location_id) filter to compare dev and prod rows right now.

@fivetran-avinash fivetran-avinash changed the base branch from main to release/v0.14.0 July 23, 2024 04:57
@fivetran-avinash fivetran-avinash changed the title Feature/locations passthrough transaction details Feature: Add locations passthrough column functionality to transaction details Jul 23, 2024
@fivetran-avinash fivetran-avinash linked an issue Jul 23, 2024 that may be closed by this pull request
4 tasks
@fivetran-avinash fivetran-avinash self-assigned this Jul 23, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@fivetran-avinash fivetran-avinash merged commit 996cf86 into release/v0.14.0 Jul 23, 2024
9 checks passed
@fastbarreto
Copy link

Hi team, I noticed this PR was merged to the release/v0.14.0 branch, but a few days ago the released one was a release-branch/v0.14.0. So this feature that I was interested just got lost. Any plans to include this in a next release then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Include location passthrough columns in transaction_details
3 participants