Feature: Add locations passthrough column functionality to transaction details #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: [#123]
This PR will result in the following new package version:
A column is being added to
netsuite2__transaction_details
.Regardless, this is likely to be folded into a larger release branch with additional updates.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🚨 Breaking Changes 🚨
location_id
to thenetsuite2__transaction_details
model. To bring this column in, a--full-refresh
after upgrading is required. (PR #125)Features
location_pass_through_columns
feature in thenetsuite2__transaction_details
model--consult the README for more details on how to passthrough additional fields. (PR #125)Under the Hood
netsuite2__transaction_details
model. (PR #125)PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Able to successfully pass through location columns.
Simple consistency test added on transaction details, run on devprod. We do an except(location_id) filter to compare dev and prod rows right now.