Feature/add fields to support account hierarchies #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra fields for intercompany reconciliation.
* Align sspecacct with upstream * Add currency_id to stg_netsuite2__subsidiaries * Fix currency_id * Update get_subsidiaries_columns.sql * Add type_based_document_number
Add fields for PR-107 in dbt_netsuite
4 tasks
fivetran-joemarkiewicz
approved these changes
Mar 19, 2024
CHANGELOG.md
Outdated
Comment on lines
5
to
11
| ## 🎉 Feature Updates 🎉 | ||
| - Fields added to support account hierarchies in the `dbt_netsuite` end model. [PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45) | ||
| - Added `is_elimination` in `stg_netsuite2__subsidiaries`. | ||
| - Added `is_eliminate` and `net_amount` in `stg_netsuite2__transaction_lines`. | ||
|
|
||
| ## Documentation Updates | ||
| - Added `display_name` in `stg_netsuite2__accounts`; added `exchange_rate` in `stg_netsuite2__transaction_accounting_lines`. [PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45) |
There was a problem hiding this comment.
Small style request to change the PR links to be in parenthesis.
Suggested change
| ## 🎉 Feature Updates 🎉 | |
| - Fields added to support account hierarchies in the `dbt_netsuite` end model. [PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45) | |
| - Added `is_elimination` in `stg_netsuite2__subsidiaries`. | |
| - Added `is_eliminate` and `net_amount` in `stg_netsuite2__transaction_lines`. | |
| ## Documentation Updates | |
| - Added `display_name` in `stg_netsuite2__accounts`; added `exchange_rate` in `stg_netsuite2__transaction_accounting_lines`. [PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45) | |
| ## 🎉 Feature Updates 🎉 | |
| - Fields added to support account hierarchies in the `dbt_netsuite` end model. ([PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45)) | |
| - Added `is_elimination` in `stg_netsuite2__subsidiaries`. | |
| - Added `is_eliminate` and `net_amount` in `stg_netsuite2__transaction_lines`. | |
| ## Documentation Updates | |
| - Added `display_name` in `stg_netsuite2__accounts`; added `exchange_rate` in `stg_netsuite2__transaction_accounting_lines`. ([PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45)) |
CHANGELOG.md
Outdated
| @@ -1,3 +1,18 @@ | |||
| # dbt_netsuite_source v0.10.0 | |||
|
|
|||
| This is part of a batch release. | |||
There was a problem hiding this comment.
I don't think this is all that necessary and can probably be removed.
Suggested change
| This is part of a batch release. |
CHANGELOG.md
Outdated
| This is part of a batch release. | ||
|
|
||
| ## 🎉 Feature Updates 🎉 | ||
| - Fields added to support account hierarchies in the `dbt_netsuite` end model. [PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45) |
There was a problem hiding this comment.
Worth calling out that this is for Netsuite2
Suggested change
| - Fields added to support account hierarchies in the `dbt_netsuite` end model. [PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45) | |
| - Fields added to support account hierarchies in the `dbt_netsuite` Netsuite2 end model. [PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45) |
CHANGELOG.md
Outdated
Comment on lines
5
to
11
| ## 🎉 Feature Updates 🎉 | ||
| - Fields added to support account hierarchies in the `dbt_netsuite` end model. [PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45) | ||
| - Added `is_elimination` in `stg_netsuite2__subsidiaries`. | ||
| - Added `is_eliminate` and `net_amount` in `stg_netsuite2__transaction_lines`. | ||
|
|
||
| ## Documentation Updates | ||
| - Added `display_name` in `stg_netsuite2__accounts`; added `exchange_rate` in `stg_netsuite2__transaction_accounting_lines`. [PR #45](https://github.com/fivetran/dbt_netsuite_source/pull/45) |
There was a problem hiding this comment.
Why are some of the new fields listed under feature updates and some listed under documentation updates? Can we instead list them all as feature updates?
There was a problem hiding this comment.
Additionally, we should call out for the new accounts, subsidiaries, and transaction_lines fields that if they are currently being passed through in the respective variables, that they will need to be removed. Otherwise they may see an error.
There was a problem hiding this comment.
Updates applied.
Co-authored-by: Joe Markiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
dbt_netsuiteissue 106 fivetran/dbt_netsuite#106This PR will result in the following new package version: 10.0 (this will be merged into a release branch I believe)
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🎉 Feature Updates 🎉
dbt_netsuiteend model. PR #45is_eliminationinstg_netsuite2__subsidiaries.is_eliminateandnet_amountinstg_netsuite2__transaction_lines.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps: See Height ticket.