Add employees model, fix timestamps, and add common fields #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra fields for intercompany reconciliation.
…ran#8) * Align sspecacct with upstream * Add currency_id to stg_netsuite2__subsidiaries * Fix currency_id * Update get_subsidiaries_columns.sql * Add type_based_document_number
addressing issues from "Merge upstream/v0.13.0" fivetran#35
For timestamp fields not converted by the NetSuite UI, cast as date
jmongerlyra
changed the title
|
Submitted a new PR w/ commits squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide your name and company
Lyra Health
Link the issue/feature request which this PR is meant to address
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
This PR addresses the following issues.
employeesmodel to support inclusion of fields like "Name", "Supervisor", in downstream models.timestampfields asdatewhere the Netsuite UI does not perform timezone conversion. These are currently stored astimestampwith the time set to midnight UTC. Keeping these fields astimestampcauses issues in reporting tools that perform automatic timezone conversion.accounts,subsidiaries,transaction_lines,transactions,transaction_accounting_lines,customers, andvendorsmodels.How did you validate the changes introduced within this PR?
Lyra maintains a fork of this repository. These changes were tested and validated there.
Which warehouse did you use to develop these changes?
Snowflake
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)