add back in period date fields (#125)

* add back in fields * updates * try new schema * Update CHANGELOG.md Co-authored-by: Joe Markiewicz <[email protected]> * Update CHANGELOG.md Co-authored-by: Avinash Kunnath <[email protected]> --------- Co-authored-by: Joe Markiewicz <[email protected]> Co-authored-by: Avinash Kunnath <[email protected]>
fivetran · May 20, 2024 · e604697 · e604697
1 parent a10932c
commit e604697
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# dbt_quickbooks v0.13.1
+[PR #125](https://github.com/fivetran/dbt_quickbooks/pull/125) includes the following updates:
+
+## Bug Fix
+- The `period_first_day` and `period_last_day` fields were mistakenly left out in the [quickbooks__profit_and_loss](https://github.com/fivetran/dbt_quickbooks/blob/main/models/quickbooks__profit_and_loss.sql) model although they were intended to be introduced as new fields [in the v0.13.0 release](https://github.com/fivetran/dbt_quickbooks/releases/tag/v0.13.0). We have added these fields into the model.
+
 # dbt_quickbooks v0.13.0
 [PR #124](https://github.com/fivetran/dbt_quickbooks/pull/124) includes the following updates:
 

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,7 +1,7 @@
 config-version: 2
 name: 'quickbooks'
 
-version: '0.13.0'
+version: '0.13.1'
 
 require-dbt-version: [">=1.3.0", "<2.0.0"]
 

diff --git a/docs/catalog.json b/docs/catalog.json
diff --git a/docs/manifest.json b/docs/manifest.json
diff --git a/docs/run_results.json b/docs/run_results.json
diff --git a/integration_tests/ci/sample.profiles.yml b/integration_tests/ci/sample.profiles.yml
@@ -16,13 +16,13 @@ integration_tests:
       pass: "{{ env_var('CI_REDSHIFT_DBT_PASS') }}"
       dbname: "{{ env_var('CI_REDSHIFT_DBT_DBNAME') }}"
       port: 5439
-      schema: quickbooks_integration_tests_04
+      schema: quickbooks_integration_tests_05
       threads: 8
     bigquery:
       type: bigquery
       method: service-account-json
       project: 'dbt-package-testing'
-      schema: quickbooks_integration_tests_04
+      schema: quickbooks_integration_tests_05
       threads: 8
       keyfile_json: "{{ env_var('GCLOUD_SERVICE_KEY') | as_native }}"
     snowflake:
@@ -33,7 +33,7 @@ integration_tests:
       role: "{{ env_var('CI_SNOWFLAKE_DBT_ROLE') }}"
       database: "{{ env_var('CI_SNOWFLAKE_DBT_DATABASE') }}"
       warehouse: "{{ env_var('CI_SNOWFLAKE_DBT_WAREHOUSE') }}"
-      schema: quickbooks_integration_tests_04
+      schema: quickbooks_integration_tests_05
       threads: 8
     postgres:
       type: postgres
@@ -42,13 +42,13 @@ integration_tests:
       pass: "{{ env_var('CI_POSTGRES_DBT_PASS') }}"
       dbname: "{{ env_var('CI_POSTGRES_DBT_DBNAME') }}"
       port: 5432
-      schema: quickbooks_integration_tests_04
+      schema: quickbooks_integration_tests_05
       threads: 8
     databricks:
       catalog: "{{ env_var('CI_DATABRICKS_DBT_CATALOG') }}"
       host: "{{ env_var('CI_DATABRICKS_DBT_HOST') }}"
       http_path: "{{ env_var('CI_DATABRICKS_DBT_HTTP_PATH') }}"
-      schema: quickbooks_integration_tests_04
+      schema: quickbooks_integration_tests_05
       threads: 8
       token: "{{ env_var('CI_DATABRICKS_DBT_TOKEN') }}"
       type: databricks
diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,6 +1,6 @@
 name: 'quickbooks_integration_tests'
 
-version: '0.13.0'
+version: '0.13.1'
 
 profile: 'integration_tests'
 config-version: 2
@@ -19,7 +19,7 @@ models:
       +materialized: view
 vars:
   quickbooks_source:
-    quickbooks_schema: quickbooks_integration_tests_04
+    quickbooks_schema: quickbooks_integration_tests_05
     quickbooks_account_identifier: "account_data"
     quickbooks_address_identifier: "address_data"
     quickbooks_bill_line_identifier: "bill_line_data"

diff --git a/models/quickbooks__profit_and_loss.sql b/models/quickbooks__profit_and_loss.sql
@@ -8,6 +8,8 @@ with general_ledger_by_period as (
 final as (
     select
         period_first_day as calendar_date, --  Slated to be deprecated; we recommend using `period_first_day` or `period_last_day`
+        period_first_day,
+        period_last_day,
         source_relation,
         account_class,
         class_id,