Adding an oop example #71
Conversation
|
| for table in selected_table: | ||
| con = table(configuration=configuration) | ||
| schema_dict = con.assign_schema() | ||
| #print(f"Schema for table {con}: {schema_dict}") |
There was a problem hiding this comment.
Remove this comment
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "api_key": "" | |||
There was a problem hiding this comment.
| "api_key": "" | |
| "api_key": "<YOUR_API_KEY>" |
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "api_key": "" | |||
| for table in selected_table: | ||
| con = table(configuration=configuration) | ||
| schema_dict = con.assign_schema() | ||
| #print(f"Schema for table {con}: {schema_dict}") |
…o adding-an-OOP-example
There was a problem hiding this comment.
PR Overview
This pull request introduces an OOP-based connector for the National Parks Service API, encapsulating logic for processing different tables (People, Parks, Articles, Alerts) and providing a new Readme to explain the connector’s structure and output.
- Implements separate classes for each table inheriting from an NPS base class.
- Refactors API fetching and data processing into modular components.
- Adds a connector file to integrate and run the different table modules.
Reviewed Changes
| File | Description |
|---|---|
| people_table.py | Adds the PEOPLE class with methods for data processing and schema definition. |
| nps_client.py | Introduces the NPS client with API interaction and configuration handling. |
| park_table.py | Implements the PARKS class for park data processing. |
| articles_table.py | Details the ARTICLES class to map article data to a schema. |
| alerts_table.py | Creates the ALERTS class for processing alert data. |
| Readme.md | Provides documentation and usage instructions for the connector. |
| connector.py | Integrates all table modules into a single connector for deployment. |
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (2)
examples/quickstart_examples/oop_example/people_table.py:75
- Both the 'title' and 'description' fields are extracted using 'listingDescription'. Verify if this is intentional or if a distinct key should be used for one of them.
title = p.get("listingDescription", "No Title") # Get title or default to "No Title"
examples/quickstart_examples/oop_example/people_table.py:4
- [nitpick] Consider using CamelCase (e.g., People) for class names instead of all uppercase to align with common Python naming conventions.
class PEOPLE(NPS):
Co-authored-by: Copilot <[email protected]>
|
@5tran-alexil please review the readme.md file |
Using the National Park Services API to use an OOP based logic to build the connector. This also has a new format with a Readme to walk through the code and show the output in the database itself vs in the code comments.