Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hello.yml #77

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

fivetran-clgritton
Copy link
Collaborator

This is a yml file that triggers GitHub actions that deploy a connector whenever code is pushed to a specific directory. It uses Environment variables and secrets to store API keys, connection names, etc.

This is a yml file that triggers GitHub actions that deploy a connector whenever code is pushed to a specific directory.
Copy link

height bot commented Feb 21, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@orizwanft orizwanft requested a review from varundhall February 24, 2025 15:59
Copy link
Collaborator

@varundhall varundhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-clgritton we need some more explanation around this change, like a README file

Also a different global folder like 'example_workflow' check with @fivetran-sadiemartin

Adding this here might confuse the customers who will think its a github workflow connector.

@orizwanft orizwanft self-assigned this Mar 4, 2025
@fivetran-clgritton
Copy link
Collaborator Author

@fivetran-sadiemartin, any thoughts on directory? /example_workflow?

@fivetran-sadiemartin
Copy link
Collaborator

@fivetran-sadiemartin, any thoughts on directory? /example_workflow?

Very interesting question about where to put this one @varundhall and @fivetran-clgritton. I think it makes sense to create a directory for example workflows since we'll be adding terraform support in the future and probably have examples related to that. @varundhall do you think "workflow" is clear enough that we're talking about automated workflows? If so, then we could call the new directory /example_workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants