-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(readme): improve layout and add all the examples with details #88
base: main
Are you sure you want to change the base?
Conversation
This pull request has been linked to and will mark 1 task as "Done" when merged:
|
@@ -1,3 +1,26 @@ | |||
<p align="center"> | |||
<a href="https://www.fivetran.com/"> | |||
<img src="https://cdn.prod.website-files.com/6130fa1501794ed4d11867ba/63d9599008ad50523f8ce26a_logo.svg" alt="Fivetran"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-sadiemartin we can add any other image here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding:
- maintained?yes as a tag
- star us on github (as seen here: https://docs.google.com/document/d/1EqmX9Yas-yEUkXuBxHYMqNLg8_fY2wTaRrw6LfGwxuU/edit?tab=t.h60uj1ev7ure#heading=h.lidymbeo0ew0)
This is looking so good @varundhall! My only concern is that the categorization you introduced for the examples on the readme doesn't match the folder structure on the repo. Is there a way to keep it to match the folder structure on the repo for now and then in the future we can revisit that categorization and keep them both aligned? |
- **[aws_dynamo_db_authentication](/examples/source_examples/aws_dynamo_db_authentication)** | ||
- This is an example of how we can connect and sync data from AWS DynamoDB by using Connector SDK. | ||
|
||
- **Common Patterns** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we actually move this example to the common patterns section since it's not a complete source implementation?
Closes https://fivetran.height.app/T-898478
Click here for preview