Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): improve layout and add all the examples with details #88

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

varundhall
Copy link
Collaborator

@varundhall varundhall commented Mar 6, 2025

Copy link

height bot commented Mar 6, 2025

This pull request has been linked to and will mark 1 task as "Done" when merged:

💡Tip: You can link multiple Height tasks to a pull request.

@@ -1,3 +1,26 @@
<p align="center">
<a href="https://www.fivetran.com/">
<img src="https://cdn.prod.website-files.com/6130fa1501794ed4d11867ba/63d9599008ad50523f8ce26a_logo.svg" alt="Fivetran">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-sadiemartin we can add any other image here as well

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-sadiemartin
Copy link
Collaborator

This is looking so good @varundhall! My only concern is that the categorization you introduced for the examples on the readme doesn't match the folder structure on the repo. Is there a way to keep it to match the folder structure on the repo for now and then in the future we can revisit that categorization and keep them both aligned?

- **[aws_dynamo_db_authentication](/examples/source_examples/aws_dynamo_db_authentication)**
- This is an example of how we can connect and sync data from AWS DynamoDB by using Connector SDK.

- **Common Patterns**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually move this example to the common patterns section since it's not a complete source implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants