feat: no SMS & Whatsapp double signup validation (#15)

* Feat:  Don't allow SMS and Whatsapp notifications to go to the same user

* Test new validation

ckanext/dataset_subscriptions/actions/user.py

@@ -146,6 +146,10 @@ def _validate_plugin_extras(extras):
             errors['activity_streams_sms_notifications'] = [
                 toolkit._('No phone number given')
             ]
+        if toolkit.asbool(extras.get('activity_streams_whatsapp_notifications')):
+            errors['activity_streams_sms_notifications'] = [
+                toolkit._('Please select either Whatsapp or SMS notifications - not both. ')
+            ]
     if toolkit.asbool(extras.get('activity_streams_whatsapp_notifications')):
         if not extras.get('phonenumber'):
             errors['activity_streams_whatsapp_notifications'] = [

ckanext/dataset_subscriptions/tests/actions/test_user.py

@@ -58,10 +58,11 @@ def test_user_validate_plugin_extras_valid_phonenumber(self, client_mock, sysadm
             helpers.call_action('user_create', context=sysadmin_context, **user_dict)
 
     @pytest.mark.parametrize('phonenumber, enable_sms, enable_whatsapp, expectation', [
-        ("", False, False, nullcontext(1)),
+        ("+44712345678", False, False, nullcontext(1)),
         ("", False, True, pytest.raises(toolkit.ValidationError)),
         ("", True, False, pytest.raises(toolkit.ValidationError)),
-        ("", True, True, pytest.raises(toolkit.ValidationError))
+        ("", True, True, pytest.raises(toolkit.ValidationError)),
+        ("+44712345678", True, True, pytest.raises(toolkit.ValidationError)),
     ])
     def test_user_validate_plugin_extras_requires_phonenumber(self, phonenumber, enable_sms,
                                                               enable_whatsapp, expectation, sysadmin_context):