Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for CKAN 2.11 #13

Merged
merged 24 commits into from
Nov 19, 2024
Merged

Upgrade for CKAN 2.11 #13

merged 24 commits into from
Nov 19, 2024

Conversation

jonathansberry
Copy link
Member

@jonathansberry jonathansberry commented Nov 18, 2024

Description

Makes a number of changes required to get ckanext-dataset-subscriptions working with CKAN 2.11.

The activity features of CKAN have been moved from core to ckanext-activity which is shipped alongside core. The changes here update the code base to reflect this. They also simplify the user_edit form, taking advantage of form refactoring that has taken place upstream in CKAN core.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

ntwalibas
ntwalibas previously approved these changes Nov 18, 2024
Copy link
Contributor

@ntwalibas ntwalibas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathansberry jonathansberry merged commit bb29619 into master Nov 19, 2024
2 checks passed
@jonathansberry jonathansberry deleted the fix/ckan-2.10 branch November 19, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants