Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements whatsapp notifications.
Since SMS and Whatsapp notifications share a great deal of logic and the same gateway, I have combined the logic into a single flow called "send_phone_notifications". This avoids having to loop through every user in the site to form a condensed copy of their dashboard activity stream twice. I would have maybe liked to find a better name for the action, but I couldn't come up with anything.
I have also refactored the code to make the send_phone_notifications action more readable without so many nested function calls.
I have also moved email_notifications code over into it's own named module.
Testing
Included tests for the whatsapp notifications and the validation of user extra fields. Also included a test to ensure that whatsapp notifications comply with pre-approved templates.
Documentation
Doc string for the send_twilio_notifications action.
Checklist
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request).You may not need to check all boxes.