-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
卒業証書のPDFファイルをアップロードできる機能を追加 #8190
Open
hagiya0121
wants to merge
13
commits into
main
Choose a base branch
from
feature/add-diploma-pdf-upload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+202
−43
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
496b8ec
卒業証書のアップロード機能を追加
hagiya0121 8385b8a
テストを追加
hagiya0121 3d8dc4e
pdfアップロードのデザインを作成
machida f3bc5cc
pdf input のsassファイルを分けた
machida d16a661
UIの変更に合わせてテストを修正
hagiya0121 fd1d8db
変数名の変更と不要なコメントを削除
hagiya0121 b2ff53d
卒業証書PDFの表記を「卒業証書(PDF)」に変更
hagiya0121 3aeb25a
削除ボタンをbutton_tagで生成するように変更
hagiya0121 6b5d653
javascriptのロジックの関数化とリファクタリング
hagiya0121 9b55b38
ファイルがアップロードされてるときのみ削除ボタンを表示
hagiya0121 7d82332
変数名とメゾッド名を変更
hagiya0121 97b19ed
ファイル名表示ロジックとイベントハンドラーのロジックを簡潔化
hagiya0121 ba692b1
変数名の変更
hagiya0121 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,47 +1,48 @@ | ||
.a-file-input | ||
label | ||
height: 10rem | ||
max-width: 100% | ||
margin-inline: auto | ||
border: solid 1px var(--input-border) | ||
background-color: var(--base) | ||
display: flex | ||
align-items: center | ||
justify-content: center | ||
+position(relative) | ||
overflow: hidden | ||
cursor: pointer | ||
border-radius: .25rem | ||
padding: .5rem .5rem 2.75rem .5rem | ||
&.is-thumbnail | ||
label | ||
height: 15rem | ||
img | ||
max-height: 100% | ||
transition: all .2s ease-out | ||
&:hover | ||
opacity: .6 | ||
&.is-square img | ||
+size(7rem) | ||
object-fit: cover | ||
&.is-book img | ||
max-height: 100% | ||
max-width: 100% | ||
object-fit: contain | ||
border: solid 1px var(--border-tint) | ||
.a-pdf-input | ||
display: flex | ||
gap: .75rem | ||
+media-breakpoint-down(sm) | ||
flex-direction: column | ||
|
||
.a-pdf-input__inner | ||
flex: 1 | ||
background-color: var(--base) | ||
display: flex | ||
align-items: center | ||
justify-content: center | ||
+position(relative) | ||
overflow: hidden | ||
cursor: pointer | ||
border-radius: .25rem | ||
height: 2.25rem | ||
input | ||
overflow: hidden | ||
+size(0) | ||
+position(absolute, left 0, top 0) | ||
opacity: 0 | ||
p | ||
+size(100% 2.25rem) | ||
background-color: var(--base) | ||
+position(absolute, left 0, bottom 0, right 0) | ||
+text-block(.8125rem 1, flex 600) | ||
justify-content: center | ||
align-items: center | ||
border-top: solid 1px var(--input-border) | ||
transition: all .2s ease-out | ||
&:hover | ||
background-color: #e8e8e8 | ||
|
||
a.a-pdf-input__inner | ||
text-decoration: none | ||
color: var(--default-text) | ||
|
||
.a-pdf-input__file | ||
padding: .5rem | ||
flex: 1 | ||
border-radius: .25rem 0 0 .25rem | ||
border: solid 1px var(--input-border) | ||
border-right: none | ||
height: 2.25rem | ||
|
||
.a-pdf-input__file-name | ||
font-size: .875rem | ||
white-space: nowrap | ||
overflow: hidden | ||
text-overflow: ellipsis | ||
display: block | ||
+media-breakpoint-up(md) | ||
max-width: 18rem | ||
+media-breakpoint-down(sm) | ||
max-width: 8rem | ||
|
||
.a-pdf-input__upload.a-button | ||
border-radius: 0 .25rem .25rem 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
.a-pdf-input | ||
display: flex | ||
gap: .75rem | ||
+media-breakpoint-down(sm) | ||
flex-direction: column | ||
|
||
.a-pdf-input__inner | ||
flex: 1 | ||
background-color: var(--base) | ||
display: flex | ||
align-items: center | ||
justify-content: center | ||
+position(relative) | ||
overflow: hidden | ||
cursor: pointer | ||
border-radius: .25rem | ||
height: 2.25rem | ||
input | ||
overflow: hidden | ||
+size(0) | ||
+position(absolute, left 0, top 0) | ||
opacity: 0 | ||
|
||
a.a-pdf-input__inner | ||
text-decoration: none | ||
color: var(--default-text) | ||
|
||
.a-pdf-input__file | ||
padding: .5rem | ||
flex: 1 | ||
border-radius: .25rem 0 0 .25rem | ||
border: solid 1px var(--input-border) | ||
border-right: none | ||
height: 2.25rem | ||
|
||
.a-pdf-input__file-name | ||
font-size: .875rem | ||
white-space: nowrap | ||
overflow: hidden | ||
text-overflow: ellipsis | ||
display: block | ||
+media-breakpoint-up(md) | ||
max-width: 18rem | ||
+media-breakpoint-down(sm) | ||
max-width: 8rem | ||
|
||
.a-pdf-input__upload.a-button | ||
border-radius: 0 .25rem .25rem 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<!DOCTYPE html> | ||
<html lang="ja"> | ||
<head> | ||
<meta charset="UTF-8" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
<title>卒業証書</title> | ||
</head> | ||
<body> | ||
<h1>卒業証書</h1> | ||
</body> | ||
</html> |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
button_tagが使えそうです!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
変更しました
3aeb25a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ファイルがアップロードされていない状態で削除ボタンがあるのはおかしい気がします🤔