ブログ記事公開時に通知先のターゲットを選択できるようにした

app/controllers/articles_controller.rb

@@ -28,7 +28,7 @@ def show
   end
 
   def new
-    @article = Article.new
+    @article = Article.new(target: 'all')
   end
 
   def edit; end
@@ -38,9 +38,7 @@ def create
     @article.user = current_user if @article.user.nil?
     set_wip
     if @article.save
-      # Newspaper.publish(:create_article, { article: @article })
-      # 上のコードのコメントアウトは、以下のissueのための一時的なものなので、mergeされ次第コメントアウトを外すこと。
-      # https://github.com/fjordllc/bootcamp/issues/8244
+      Newspaper.publish(:create_article, { article: @article })
 
       redirect_to redirect_url(@article), notice: notice_message(@article)
     else
@@ -95,6 +93,7 @@ def article_params
       thumbnail_type
       summary
       display_thumbnail_in_body
+      target
     ]
     article_attributes.push(:published_at) unless params[:commit] == 'WIP'
     article_attributes.push(:token) if params[:commit] == 'WIP'

app/javascript/article-target.js

@@ -0,0 +1,61 @@
+document.addEventListener('DOMContentLoaded', () => {
+  const radioButtons = document.querySelectorAll(
+    'input[name="article[target]"]'
+  )
+  const defaultTarget = document.querySelector(
+    'input[name="article[target]"]:checked'
+  )
+  if (!defaultTarget) {
+    return
+  }
+  let target = defaultTarget.value
+  let targetName = document
+    .querySelector(`label[for="${defaultTarget.id}"]`)
+    .textContent.trim()
+  let text = setAlertText(target, targetName)
+
+  radioButtons.forEach((radio) => {
+    radio.addEventListener('change', (event) => {
+      target = event.target.value
+      targetName = document
+        .querySelector(`label[for="${radio.id}"]`)
+        .textContent.trim()
+      text = setAlertText(target, targetName)
+    })
+  })
+
+  const form = document.getElementById('article_form')
+  const submitButtons = form.querySelectorAll(
+    'input[type="submit"',
+    'button[type="submit"]'
+  )
+  const publishButton = document.getElementById('js-shortcut-submit')
+  let isPublish = false
+  publishButton.addEventListener('click', () => {
+    isPublish = true
+  })
+
+  form.addEventListener('submit', (event) => {
+    if (isPublish) {
+      submitButtons.forEach((button) => {
+        button.removeAttribute('data-disable-with')
+      })
+      if (!window.confirm(text)) {
+        event.preventDefault()
+        isPublish = false
+      } else {
+        submitButtons.forEach((button) => {
+          button.disabled = true
+        })
+      }
+    }
+  })
+})
+
+function setAlertText(target, targetName) {
+  if (target === 'none') {
+    return '「通知しない」が選択されています。よろしいですか？'
+  } else {
+    return `この記事を公開すると、${targetName}に通知が送られます。もし記事に誤った情報が含まれている場合、その通知を受け取った人を介してSNSなどで拡散される可能性があります。そのため、記事内の年月日などに間違いがないか、しっかり確認してください。公開しても問題ありませんか？`
+  }
+}

app/javascript/packs/application.js

@@ -64,6 +64,7 @@ import '../micro-reports.js'
 import '../answer.js'
 import '../new-answer.js'
 import '../coding-test.js'
+import '../article-target.js'
 
 import VueMounter from '../VueMounter.js'
 import Questions from '../components/questions.vue'

app/models/announcement_notifier.rb

@@ -9,7 +9,7 @@ def call(payload)
     DiscordNotifier.with(announce: announcement).announced.notify_now
     Watch.create!(user: announcement.user, watchable: announcement)
 
-    receivers = User.announcement_receiver(announcement.target).reject { |receiver| receiver == announcement.sender }
+    receivers = User.notification_receiver(announcement.target).reject { |receiver| receiver == announcement.sender }
     PostAnnouncementJob.perform_later(announcement, receivers)
   end
 end

app/models/article.rb

@@ -17,6 +17,13 @@ class Article < ApplicationRecord
     blue: 12
   }
 
+  enum target: {
+    all: 0,
+    students: 1,
+    job_seekers: 2,
+    none: 3
+  }, _prefix: true
+
   belongs_to :user
   alias sender user
   include ActionView::Helpers::AssetUrlHelper
@@ -34,6 +41,8 @@ class Article < ApplicationRecord
             content_type: %w[image/png image/jpg image/jpeg],
             size: { less_than: 10.megabytes }
 
+  after_validation :reset_published_at_if_invalid
+
   paginates_per 24
   acts_as_taggable
 
@@ -57,6 +66,10 @@ def published?
     !wip?
   end
 
+  def before_initial_publish?
+    published_at.nil?
+  end
+
   def generate_token!
     self.token ||= SecureRandom.urlsafe_base64
   end
@@ -70,4 +83,10 @@ def will_be_published?
   def set_published_at
     self.published_at = Time.current
   end
+
+  def reset_published_at_if_invalid
+    return unless errors.any?
+
+    self.published_at = nil
+  end
 end

app/models/article_notifier.rb

@@ -5,7 +5,7 @@ def call(payload)
     article = payload[:article]
     return unless article.saved_change_to_attribute?(:published_at, from: nil)
 
-    receivers = User.students_trainees_mentors_and_admins.reject { |receiver| receiver == article.user }
+    receivers = User.notification_receiver(article.target).reject { |receiver| receiver == article.sender }
     send_notification(article:, receivers:)
   end
 

app/models/user.rb

@@ -446,14 +446,16 @@ class User < ApplicationRecord
   )
 
   class << self
-    def announcement_receiver(target)
+    def notification_receiver(target)
       case target
       when 'all'
         User.unretired
       when 'students'
         User.admins_and_mentors.or(User.students)
       when 'job_seekers'
         User.admins_and_mentors.or(User.job_seekers)
+      when 'none'
+        User.none
       else
         User.none
       end

app/views/articles/_form.html.slim

@@ -1,5 +1,5 @@
 = render 'errors', object: @article
-= form_with(model: article, local: true) do |f|
+= form_with(model: article, local: true, id: 'article_form') do |f|
   .form__items
     .form-item
       .row
@@ -139,6 +139,41 @@
                     p
                       | WIPで保存した場合は、記事公開日時は保存されません。
 
+    - if article.before_initial_publish?
+      .form-item
+        label.a-form-label
+          | 通知ターゲット
+          .a-form-help
+            p
+              | 通知は初回公開時のみ行われます。
+        ul.block-checks.is-3-items
+          li.block-checks__item
+            .a-block-check.is-radio
+              = f.radio_button :target, 'all', id: 'all', class: 'a-toggle-checkbox'
+              label.a-block-check__label(for='all')
+                = t('activerecord.enums.article.target.all')
+          li.block-checks__item
+            .a-block-check.is-radio
+              = f.radio_button :target, 'students', id: 'students', class: 'a-toggle-checkbox'
+              label.a-block-check__label(for='students')
+                = t('activerecord.enums.article.target.students')
+          li.block-checks__item
+            .a-block-check.is-radio
+              = f.radio_button :target, 'job_seekers', id: 'job_seekers', class: 'a-toggle-checkbox'
+              label.a-block-check__label(for='job_seekers')
+                = t('activerecord.enums.article.target.job_seekers')
+          li.block-checks__item
+            .a-block-check.is-radio
+              = f.radio_button :target, 'none', id: 'none', class: 'a-toggle-checkbox'
+              label.a-block-check__label(for='none')
+                =t('activerecord.enums.article.target.none')
+    - elsif article.target == 'none'
+      p
+        | この記事は通知を行わずに公開しました。
+    - else
+      p
+        = "この記事は初回公開時に#{t("activerecord.enums.article.target.#{article.target}")}に対してすでに通知を行っています。"
+
   .form-actions
     ul.form-actions__items
       li.form-actions__item.is-main

config/locales/ja.yml

@@ -384,6 +384,11 @@ ja:
           orange: Orange
           brown: Brown
           blue: Blue
+        target:
+          all: 全員（退会者を除く）
+          students: 現役生のみ
+          job_seekers: 就職希望者のみ
+          none: 通知しない
     errors:
       models:
         campaign:

db/migrate/20250121062719_add_target_to_articles.rb

@@ -0,0 +1,5 @@
+class AddTargetToArticles < ActiveRecord::Migration[6.1]
+  def change
+    add_column :articles, :target, :integer
+  end
+end

db/schema.rb

@@ -79,6 +79,7 @@
     t.integer "thumbnail_type", default: 0, null: false
     t.string "token"
     t.boolean "display_thumbnail_in_body", default: true, null: false
+    t.integer "target", default: 0
     t.index ["user_id"], name: "index_articles_on_user_id"
   end
 

test/models/article_test.rb

@@ -28,6 +28,11 @@ class ArticleTest < ActiveSupport::TestCase
     assert_not articles(:article3).published?
   end
 
+  test '#before_initial_publish?' do
+    assert_not articles(:article1).before_initial_publish?
+    assert articles(:article3).before_initial_publish?
+  end
+
   test '#generate_token!' do
     test_article = Article.create(
       title: 'サンプル記事',

test/models/user_test.rb

@@ -213,14 +213,14 @@ class UserTest < ActiveSupport::TestCase
     assert user.invalid?
   end
 
-  test 'announcment for all' do
-    target = User.announcement_receiver('all')
+  test 'notification for all' do
+    target = User.notification_receiver('all')
     assert_includes(target, users(:kimura))
     assert_not_includes(target, users(:yameo))
   end
 
-  test 'announcment for students' do
-    target = User.announcement_receiver('students')
+  test 'notification for students' do
+    target = User.notification_receiver('students')
     assert_includes(target, users(:kimura))
     assert_includes(target, users(:komagata))
     assert_includes(target, users(:mentormentaro))
@@ -230,8 +230,8 @@ class UserTest < ActiveSupport::TestCase
     assert_not_includes(target, users(:kensyu))
   end
 
-  test 'announcment for job_seekers' do
-    target = User.announcement_receiver('job_seekers')
+  test 'notification for job_seekers' do
+    target = User.notification_receiver('job_seekers')
     assert_includes(target, users(:jobseeker))
     assert_includes(target, users(:komagata))
     assert_includes(target, users(:sotugyou))
@@ -241,6 +241,18 @@ class UserTest < ActiveSupport::TestCase
     assert_not_includes(target, users(:yameo))
   end
 
+  test 'notification for none' do
+    target = User.notification_receiver('none')
+    assert_not_includes(target, users(:kimura))
+    assert_not_includes(target, users(:jobseeker))
+    assert_not_includes(target, users(:komagata))
+    assert_not_includes(target, users(:mentormentaro))
+    assert_not_includes(target, users(:sotugyou))
+    assert_not_includes(target, users(:advijirou))
+    assert_not_includes(target, users(:kensyu))
+    assert_not_includes(target, users(:yameo))
+  end
+
   test '#follow' do
     kimura = users(:kimura)
     hatsuno = users(:hatsuno)

test/system/article/tags_test.rb

@@ -13,8 +13,10 @@ class Article::TagsTest < ApplicationSystemTestCase
     end
     assert page.has_text?(tags.first)
     assert page.has_text?(tags.second)
-    click_on '公開する'
-
+    page.accept_confirm do
+      click_on '公開する'
+    end
+    assert_text '記事を作成しました'
     created_article = Article.find_by(title: 'タグ追加のテスト記事')
     assert_equal tags, created_article.tag_list.sort
   end