ElapsedDaysをReactから素のJSに置き換えた #8371
Open
+110
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ryooo-k |
|
@harada-webdev |
|
@Ryooo-k |
Ryooo-k
reviewed
Mar 4, 2025
| countProductsGroupedBy={countProductsGroupedBy} | ||
| productDeadlineDay={productDeadlineDay} | ||
| /> | ||
| <div className="page-body__column is-sub" ref={elapsedDaysRef}></div> |
There was a problem hiding this comment.
元々のコードに合わせて、下記のようにした方が良いかなーと思いました！
Suggested change
| <div className="page-body__column is-sub" ref={elapsedDaysRef}></div> | |
| <nav className="page-body__column is-sub" ref={elapsedDaysRef}></nav> |
| return span | ||
| } | ||
|
|
||
| const nav = document.createElement('nav') |
There was a problem hiding this comment.
こちらのコメントのようにすると、navは不要になりそうだと思いました。
| const li = document.createElement('li') | ||
| li.className = `page-nav__item ${additionalClass} ${activeClass( | ||
| countProductsGroupedBy(elapsedDays) | ||
| )}`.trim() |
There was a problem hiding this comment.
教えてください🙇ここのtrim()がなぜ必要なのかがわからなかったです💦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
未アサインの提出物で表示されている、提出されてから何日経過しているかを示すナビゲーションメニューのコードを非Reactし、素のJSに置き換えました。
確認方法
mainブランチでforeman start -f Procfile.devを実行して開発環境を立ち上げるkomagata、パスワードtesttestでログインするchore/replace-elapsed-days-with-vanilla-jsで表示されている内容と比較するために、ここでスクショを撮るchore/rewrite-elapsed-days-to-vanilla-jsに変更するi.
git fetch origin chore/rewrite-elapsed-days-to-vanilla-jsii.
git checkout chore/rewrite-elapsed-days-to-vanilla-jsmainと変わっていないことを確認するScreenshot
未アサインの提出物ページ
rails db:seedして、提出時刻が最新に更新された提出物情報を入手した場合
※CSS確認用
提出してから3日以内の提出物しかない場合
提出してから4日以上の提出物しかない場合