refactor: refactored gettype method #997
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fkhadra can you please review this PR? |
ianstreator
reviewed
Nov 12, 2023
example/components/ToastCode.tsx
Outdated
| case 'warning': | ||
| return 'toast.warn'; | ||
| } | ||
| return typeMap[type] || 'toast'; |
There was a problem hiding this comment.
using the OR operator to default to string literal 'toast', but typeMap already has a default field set to 'toast'.
return typeMap[type] || typeMap.default
There was a problem hiding this comment.
PR feedback incorporated could you please check again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Refactor getType method