Resolve the C4800 warnings when compiled with MSVC compilers #430
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the C4800 warnings when this library is compiled with a MSVC compiler as reported in the issue #429.
The warnings are now resolved by
static_cast
ing the result ofstd::isalnum()
asbool
.Furthermore, the test suite is now built with the compile option
/w44800
to avoid a possible regression in the future (the C4800 warning is desabled by default and even with the compile option/W4
).Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.