Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the C4800 warnings when compiled with MSVC compilers #430

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Nov 18, 2024

This PR fixes the C4800 warnings when this library is compiled with a MSVC compiler as reported in the issue #429.
The warnings are now resolved by static_casting the result of std::isalnum() as bool.
Furthermore, the test suite is now built with the compile option /w44800 to avoid a possible regression in the future (the C4800 warning is desabled by default and even with the compile option /W4).


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Nov 18, 2024
@fktn-k fktn-k added this to the Release v0.3.15 milestone Nov 18, 2024
@fktn-k fktn-k self-assigned this Nov 18, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit bf436d7a114d866dd1e25c8404eece60b7df387f.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr430.zip
ID 2202350201
URL https://github.com/fktn-k/fkYAML/actions/runs/11895933022/artifacts/2202350201

@fktn-k
Copy link
Owner Author

fktn-k commented Nov 18, 2024

macos-12 is now deprecated and it's during the scheduled brownout period now.
actions/runner-images#10721
That's why all the workflow jobs using the macos-12 runner are failing...
I'll re-run those failed jobs tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant