fix: Only use pre-set ReadonlySizeProvider for sizing in HudMarginComponent #2611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a project where we wrapped the
JoystickComponent
into it's ownComponent
to separate concerns resizing the window (or hot reloading) would throw an exception leading to a red screen.The
HudMarginComponent
currently expects the parent to be either aFlameGame
orReadOnlySizeProvider
, which throws an exception when our wrappedJoystick
class is neither.With the help of @spydon, we came to the conclusion that this fix should work and not break other cases.
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues
No related issue, I can open one if needed.