Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect artboard clip value #2639

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

zacherygentry
Copy link
Contributor

@zacherygentry zacherygentry commented Aug 4, 2023

Description

Adds a check for the artboard's clip value before actually clipping

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #2638

@zacherygentry
Copy link
Contributor Author

zacherygentry commented Aug 4, 2023

Still relatively new to flame, maybe someone more familiar could help me get this over the finish line by adding a test and fixing the failing test?

@zacherygentry zacherygentry changed the title respect artboard clip value fix: respect artboard clip value Aug 4, 2023
@spydon spydon changed the title fix: respect artboard clip value fix: Respect artboard clip value Aug 7, 2023
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for you contribution!

@spydon spydon merged commit 4e66424 into flame-engine:main Aug 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flame Rive component does not respect the artboard's clip value
2 participants