Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(overlays): Added the 'priority' parameter for overlays #3349

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

raspberry-jenshen
Copy link
Contributor

@raspberry-jenshen raspberry-jenshen commented Oct 19, 2024

Description

To sort overlays we can introduce a priority.
Let's say my app contains several menus that can be displayed simultaneously, but I want my main menu displayed at first in the stack (at the bottom).

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this was going to be a breaking change, good job in not making it so. Lgtm!

@spydon
Copy link
Member

spydon commented Oct 20, 2024

I just realized that docs are missing @raspberry-jenshen, if you can just add a short paragraph and example for it here:
https://github.com/flame-engine/flame/blob/main/doc/flame/overlays.md

@raspberry-jenshen
Copy link
Contributor Author

All done!

Please check @spydon

Screenshot 2024-10-21 at 16 18 01

@spydon
Copy link
Member

spydon commented Oct 21, 2024

Some markdown linting issue, but otherwise it looks good :)

doc/flame/overlays.md:23:81 MD013/line-length Line length [Expected: 80; Actual: 129]

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@spydon spydon merged commit e591ebf into flame-engine:main Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants