Merge pull request #1592 from flanksource/update-inline-canary-name

fix: creation of multiple inline canaries for a component
flanksource · Jan 18, 2024 · 04cd87a · 04cd87a
2 parents e404a77 + c621f5f
commit 04cd87a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/topology/component_check.go b/pkg/topology/component_check.go
@@ -75,7 +75,7 @@ func createComponentCanaryFromInline(gormDB *gorm.DB, id, name, namespace, sched
 
 func GetChecksForComponent(ctx context.Context, component *pkg.Component) ([]models.CheckComponentRelationship, error) {
 	var relationships []models.CheckComponentRelationship
-	for _, componentCheck := range component.ComponentChecks {
+	for idx, componentCheck := range component.ComponentChecks {
 		hash := componentCheck.Hash()
 		if componentCheck.Selector.LabelSelector != "" {
 			checks, err := duty.FindChecks(ctx, types.ResourceSelectors{componentCheck.Selector}, duty.PickColumns("id", "canary_id"))
@@ -98,8 +98,9 @@ func GetChecksForComponent(ctx context.Context, component *pkg.Component) ([]mod
 				inlineSchedule = componentCheck.Inline.Schedule
 			}
 
+			canaryName := fmt.Sprintf("%s-%d", component.Name, idx)
 			canary, err := createComponentCanaryFromInline(ctx.DB(),
-				component.ID.String(), component.Name, component.Namespace,
+				component.ID.String(), canaryName, component.Namespace,
 				inlineSchedule, component.Owner, componentCheck.Inline,
 			)