fix: deletion logic for transformed checks (#1143)

* fix: deletion logic for transformed checks

* fix: lint error

* fix: nil uuid edge case when persisiting checks

* feat: add transform delete strategy

* chore: update manifests

* chore: fix lint

* chore: use constants and check statuses for transformed

* chore: fix lint

api/external/api.go

@@ -11,6 +11,7 @@ type Describable interface {
 	GetIcon() string
 	GetName() string
 	GetLabels() map[string]string
+	GetTransformDeleteStrategy() string
 }
 
 type WithType interface {

api/v1/checks.go

@@ -15,6 +15,11 @@ import (
 	"k8s.io/client-go/kubernetes"
 )
 
+const (
+	OnTransformMarkHealthy   = "MarkHealthy"
+	OnTransformMarkUnhealthy = "MarkUnhealthy"
+)
+
 type checkContext interface {
 	context.Context
 	HydrateConnectionByURL(connectionName string) (*models.Connection, error)

api/v1/common.go

@@ -280,6 +280,8 @@ type Description struct {
 	Icon string `yaml:"icon,omitempty" json:"icon,omitempty" template:"true"`
 	// Labels for the check
 	Labels Labels `yaml:"labels,omitempty" json:"labels,omitempty"`
+	// Transformed checks have a delete strategy on deletion they can either be marked healthy, unhealthy or left as is
+	TransformDeleteStrategy string `yaml:"transformDeleteStrategy,omitempty" json:"transformDeleteStrategy,omitempty"`
 }
 
 func (d Description) String() string {
@@ -305,6 +307,10 @@ func (d Description) GetLabels() map[string]string {
 	return d.Labels
 }
 
+func (d Description) GetTransformDeleteStrategy() string {
+	return d.TransformDeleteStrategy
+}
+
 type Connection struct {
 	// Connection name e.g. connection://http/google
 	Connection string `yaml:"connection,omitempty" json:"connection,omitempty"`

checks/common.go

@@ -84,6 +84,7 @@ func transform(ctx *context.Context, in *pkg.CheckResult) ([]*pkg.CheckResult, e
 		t.Name = def(t.Name, in.Check.GetName())
 		t.Type = def(t.Type, in.Check.GetType())
 		t.Endpoint = def(t.Endpoint, in.Check.GetEndpoint())
+		t.TransformDeleteStrategy = def(t.TransformDeleteStrategy, in.Check.GetTransformDeleteStrategy())
 		r := t.ToCheckResult()
 		r.Canary = in.Canary
 		r.Canary.Namespace = def(t.Namespace, r.Canary.Namespace)
@@ -96,6 +97,7 @@ func transform(ctx *context.Context, in *pkg.CheckResult) ([]*pkg.CheckResult, e
 		// We use this label to set the transformed column to true
 		// This label is used and then removed in pkg.FromV1 function
 		r.Canary.Labels["transformed"] = "true" //nolint:goconst
+		r.Transformed = true
 		results = append(results, &r)
 	}