feat: use check label in metrics (#2257)

* feat: use check label in metrics * feat: accept additional check labels for metrics from the CLI * chore: update chart
flanksource · Oct 21, 2024 · 2cbb486 · 2cbb486
1 parent 59d477e
commit 2cbb486
Show file tree

Hide file tree

Showing 6 changed files with 337 additions and 128 deletions.
diff --git a/api/v1/checks.go b/api/v1/checks.go
@@ -17,6 +17,10 @@ import (
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 )
 
+// List of additional check label keys that should be included in the check metrics.
+// By default the labels metrics are not exposed.
+var AdditionalCheckMetricLabels []string
+
 const (
 	OnTransformMarkHealthy   = "MarkHealthy"
 	OnTransformMarkUnhealthy = "MarkUnhealthy"

diff --git a/chart/templates/deployment.yaml b/chart/templates/deployment.yaml
@@ -193,6 +193,9 @@ spec:
             {{- if (tpl .Values.otel.collector .) }}
             - --otel-collector-url={{ tpl .Values.otel.collector . | default "" }}
             {{- end }}
+            {{- if .Values.labelsAllowList}}
+            - --metric-labels-allowlist={{ join "," .Values.labelsAllowList }}
+            {{- end}}
             {{- if (tpl .Values.otel.serviceName .) }}
             - --otel-service-name={{ tpl .Values.otel.serviceName . | default "canary-checker" }}
             {{- end }}