Skip to content

Commit

Permalink
refactor: rename 'enable' to 'enabled' in the helm chart (#2297)
Browse files Browse the repository at this point in the history
* refactor: rename 'enable' to 'enabled' in the helm chart

* fix: update chart README and values json files
  • Loading branch information
santilococo authored Oct 31, 2024
1 parent 13b382a commit 3a2ee3f
Show file tree
Hide file tree
Showing 5 changed files with 150 additions and 52 deletions.
5 changes: 3 additions & 2 deletions chart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Kubernetes native, multi-tenant synthetic monitoring system

| Repository | Name | Version |
|------------|------|---------|
| https://flanksource.github.io/charts | flanksource-ui | 1.0.757 |
| https://flanksource.github.io/charts | flanksource-ui | 1.0.772 |

## Values

Expand Down Expand Up @@ -64,6 +64,7 @@ Kubernetes native, multi-tenant synthetic monitoring system
| ingress.host | string | `"canary-checker"` | |
| ingress.tls | list | `[]` | |
| jsonLogs | bool | `true` | |
| labelsAllowList | list | `[]` | List of additional check label keys that should be included in the check metrics |
| livenessProbe.httpGet.path | string | `"/health"` | |
| livenessProbe.httpGet.port | int | `8080` | |
| logLevel | string | `""` | |
Expand All @@ -88,7 +89,7 @@ Kubernetes native, multi-tenant synthetic monitoring system
| serviceAccount.name | string | `"canary-checker-sa"` | |
| serviceAccount.rbac.clusterRole | bool | `true` | whether to create cluster-wide or namespaced roles |
| serviceAccount.rbac.configmaps | bool | `true` | for secret management with valueFrom |
| serviceAccount.rbac.enable | bool | `true` | Install (Cluster)Role and RoleBinding for the ServiceAccount |
| serviceAccount.rbac.enabled | bool | `true` | Install (Cluster)Role and RoleBinding for the ServiceAccount |
| serviceAccount.rbac.exec | bool | `true` | |
| serviceAccount.rbac.ingressCreateAndDelete | bool | `true` | for pod canary |
| serviceAccount.rbac.namespaceCreateAndDelete | bool | `true` | for namespace canary |
Expand Down
2 changes: 1 addition & 1 deletion chart/templates/rbac.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.serviceAccount.rbac.enable }}
{{- if .Values.serviceAccount.rbac.enabled }}
apiVersion: rbac.authorization.k8s.io/v1
kind: "{{if .Values.serviceAccount.rbac.clusterRole}}Cluster{{end}}Role"
metadata:
Expand Down
Loading

0 comments on commit 3a2ee3f

Please sign in to comment.