Merge pull request #1648 from flanksource/fix-range-error

fix: cleanup canary out of range error
flanksource · Feb 2, 2024 · 9c34c97 · 9c34c97
2 parents 0cdd1ac + d04a1ac
commit 9c34c97
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/topology/cleanup.go b/pkg/topology/cleanup.go
@@ -66,12 +66,13 @@ var CleanupCanaries = &job.Job{
 	Retention:  job.Retention3Day,
 	RunNow:     true,
 	Fn: func(ctx job.JobRuntime) error {
+		retention := ctx.Properties().Duration("canary.retention.age", DefaultRetention)
 		tx := ctx.DB().Exec(`
 		DELETE FROM canaries
 		WHERE
 				id NOT IN (SELECT canary_id FROM checks) AND
-				(NOW() - deleted_at) > INTERVAL '1 day' * ?
-		`, ctx.Properties().Duration("canary.retention.age", DefaultRetention))
+				(NOW() - deleted_at) > INTERVAL '1 second' * ?
+		`, int64(retention.Seconds()))
 
 		ctx.History.SuccessCount = int(tx.RowsAffected)
 		return tx.Error