fix: templating of kubernetes resource checks

* fix how results of checks are handled in kubernetes resouce checks

api/v1/checks.go

@@ -777,6 +777,10 @@ func (c ConfigDBCheck) GetEndpoint() string {
 	return c.Query
 }
 
+// KubernetesResourceChecks is the canary spec.
+// NOTE: It's only created to make crd generation possible.
+// embedding CanarySpec into KubernetesResourceCheck.checks
+// directly generates an invalid crd.
 type KubernetesResourceChecks struct {
 	CanarySpec `yaml:",inline" json:",inline"`
 }
@@ -813,7 +817,7 @@ func (c KubernetesResourceCheck) GetType() string {
 }
 
 func (c KubernetesResourceCheck) GetEndpoint() string {
-	return "" // TODO:
+	return c.Name
 }
 
 type ResourceSelector struct {

checks/kubernetes_resource.go

@@ -5,6 +5,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/flanksource/gomplate/v3"
 	"github.com/flanksource/is-healthy/pkg/health"
 	"golang.org/x/sync/errgroup"
 
@@ -150,23 +151,39 @@ func (c *KubernetesResourceChecker) Check(ctx *context.Context, check v1.Kuberne
 		}
 	}
 
-	// run the actual check now. We need to run this in a canary-checker pod as well
 	logger.Debugf("found %d checks to run", len(check.Checks))
 	for _, c := range check.Checks {
 		virtualCanary := v1.Canary{
 			ObjectMeta: ctx.Canary.ObjectMeta,
 			Spec:       c.CanarySpec,
 		}
 
-		logger.Infof("running check inside kubernetes resource")
+		templater := gomplate.StructTemplater{
+			Values: map[string]any{
+				"staticResource": check.StaticResources,
+				"resources":      check.Resources,
+			},
+			ValueFunctions: true,
+			DelimSets: []gomplate.Delims{
+				{Left: "{{", Right: "}}"},
+				{Left: "$(", Right: ")"},
+			},
+		}
+		if err := templater.Walk(&virtualCanary); err != nil {
+			return results.Failf("error templating checks %v", err)
+		}
 
 		checkCtx := context.New(ctx.Context, virtualCanary)
 		res, err := Exec(checkCtx)
 		if err != nil {
 			return results.Failf("%v", err)
+		} else {
+			for _, r := range res {
+				if r.Error != "" {
+					results.Failf("check (name:%s) failed with error: %v", r.GetName(), r.Error)
+				}
+			}
 		}
-
-		results = append(results, res...)
 	}
 
 	return results

fixtures/k8s/ingress_accessibility.yaml

@@ -8,7 +8,7 @@ spec:
   schedule: '@every 5m'
   kubernetesResource:
     - name: ingress-accessibility-check 
-      description: "deploy a pod and check that it is accessible via ingress"
+      description: "deploy an nginx pod"
       namespace: default
       resources:
         - apiVersion: v1
@@ -23,8 +23,3 @@ spec:
                   - containerPort: 80
       waitForReady: true 
       timeout: 10m
-      podChecks:
-      checks:
-        - http:
-          - name: adityathebe.com.np
-            url: "https://adityathebe.com.np"