Merge pull request #1256 from flanksource/fix/canary-sync-from-ui

fix: canaries created from UI were not being saved
flanksource · Sep 12, 2023 · d8d046e · d8d046e
2 parents 73fe256 + 7d354be
commit d8d046e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/api.go b/pkg/api.go
@@ -243,7 +243,10 @@ func FromResult(result CheckResult) CheckStatus {
 
 func FromV1(canary v1.Canary, check external.Check, statuses ...CheckStatus) Check {
 	canaryID, _ := uuid.Parse(canary.GetPersistedID())
+	checkID, _ := uuid.Parse(canary.GetCheckID(check.GetName()))
+
 	c := Check{
+		ID:       checkID,
 		Owner:    canary.Spec.Owner,
 		Severity: canary.Spec.Severity,
 		// DisplayType: check.DisplayType,

diff --git a/pkg/cache/postgres.go b/pkg/cache/postgres.go
@@ -54,7 +54,7 @@ func (c *postgresCache) AddCheckFromStatus(check pkg.Check, status pkg.CheckStat
 		return uuid.Nil, nil
 	}
 
-	if !check.Transformed {
+	if check.ID != uuid.Nil {
 		return uuid.Nil, nil
 	}