chore: delete transformed checks from cron #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
commented
Jul 10, 2023
| @@ -51,7 +51,8 @@ func StartScanCanaryConfigs(dataFile string, configFiles []string) { | |||
| type CanaryJob struct { | |||
| *kommons.Client | |||
| Kubernetes kubernetes.Interface | |||
| v1.Canary | |||
| Canary v1.Canary | |||
| DBCanary pkg.Canary | |||
There was a problem hiding this comment.
Will use DB object from now on, will slowly deprecate uses of the old spec
yashmehrotra
force-pushed
the
remove-transformed-checks-from-cron
branch
from
1eecedd
to
1699d55
Compare
moshloop
reviewed
Jul 10, 2023
yashmehrotra
force-pushed
the
remove-transformed-checks-from-cron
branch
from
fd555d7
to
5906b72
Compare
yashmehrotra
commented
Jul 11, 2023
| @@ -96,10 +96,6 @@ func PersistCheck(check pkg.Check, canaryID uuid.UUID) (uuid.UUID, error) { | |||
| "deleted_at": nil, | |||
| } | |||
|
|
|||
| // Deletions for transformed checks are handled separately | |||
There was a problem hiding this comment.
@moshloop
Not sure why we put this, removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://mission-control.azure.lab.flanksource.com/incidents/018929f8-be24-2368-7983-a4e47955d5b5