refactor: move common test logic to separate package #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
test-commons
branch
from
4b3364b
to
c2c1c2f
Compare
|
@moshloop @adityathebe Should I move this to the commons repo ? we can probably re-use this for incident commander as well |
I don't think commons is the right place as it will incresae the dependency tree, duty is probably a better place |
yashmehrotra
force-pushed
the
test-commons
branch
from
c2c1c2f
to
34599d4
Compare
yashmehrotra
force-pushed
the
test-commons
branch
from
34599d4
to
8c8577d
Compare
yashmehrotra
force-pushed
the
test-commons
branch
from
50a3da3
to
7f7060f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go.mod after flanksource/duty#235 is merged