-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git Pull-Push checker #1283
Git Pull-Push checker #1283
Conversation
Hi @wwwlde Thank you for contribution ! - Just a couple small items should be good to merge |
a59c56c
to
46d04f4
Compare
c518946
to
e4bb0bc
Compare
@moshloop Hello, could you take a look at the PR again? Is everything as you expected now? Thanks in advance! |
256344a
to
3ea7278
Compare
3ea7278
to
ca50ca1
Compare
…ource#1291) * feat: only run sync jobs for canaries of specified namespaces * chore: fix typo & lint error
70db096
to
0b2b542
Compare
@moshloop I fixed the linter for CRD. P.S. I hope everything is fine with you and you are safe. Victory and peace to Israel! |
@wwwlde thank you for the support Can we add back the fixture and use these setup files to create a gogs server we can test against? https://gist.github.com/moshloop/d2cc77696a543588b863cece88e29969 |
I apologize, I was just about to upload it yesterday but didn't manage to. I did it through gogs, but I see gitea already. Could you please check if this version is okay? Thank you in advance! |
@moshloop Hello, could you please review the PR now? Is everything okay? |
@wwwlde Looking good :) - Can you move the creation of the github token into if statement as it will fail in tests on forks (but the git protocol test shouls still pass): # creating a GITHUB_TOKEN Secret
if [[ -z "${GH_TOKEN}" ]]; then
printf "\nEnvironment variable for github token (GH_TOKEN) is missing!!!\n"
else
printf "\nCreating secret from github token ending with '${GH_TOKEN:(-8)}'\n"
kubectl create secret generic github-token --from-literal=GITHUB_TOKEN="${GH_TOKEN}" --namespace canaries
kubectl get secret github-token -o yaml --namespace canaries
fi |
@moshloop Done |
@moshloop I also fixed the issue with the linters. |
@moshloop Hello, May I inquire if there is anything else needed? What I have done in the tests seems correct, but they are still failing - you might want to take a look to see what's wrong. |
@wwwlde Looks like the failing tests are unrelated now, merging :) |
🎉🎉🎉 @moshloop Thanks! |
Hello,
I'm not sure if you need this, but for my purposes (calculating SLO) I've created this checker for GitLab. The goal was simple - to ensure that it's possible to fetch and send commits. If there are any comments or feedback, I'll try to find the time to fix/add something. I'd be very grateful if you could approve this PR request.
Have a great day!