feat: new kubernetes resource check #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/new-kubernetes-check
branch
4 times, most recently
from
609fca2
to
1fafac7
Compare
moshloop
reviewed
Apr 1, 2024
adityathebe
force-pushed
the
feat/new-kubernetes-check
branch
2 times, most recently
from
3783e3b
to
747c52c
Compare
moshloop
reviewed
Apr 2, 2024
adityathebe
force-pushed
the
feat/new-kubernetes-check
branch
12 times, most recently
from
4c5a4f4
to
e290443
Compare
moshloop
reviewed
Apr 4, 2024
moshloop
reviewed
Apr 4, 2024
moshloop
reviewed
Apr 4, 2024
adityathebe
force-pushed
the
feat/new-kubernetes-check
branch
4 times, most recently
from
56fb315
to
f3fed88
Compare
adityathebe
force-pushed
the
feat/new-kubernetes-check
branch
2 times, most recently
from
b249a2c
to
065e961
Compare
adityathebe
commented
Apr 8, 2024
| - name: hello-world | ||
| image: hello-world | ||
| waitFor: | ||
| expr: 'dyn(resources).all(r, k8s.getHealth(r).status == "Healthy")' |
There was a problem hiding this comment.
should be replaced by k8s.isReady once we add it
adityathebe
commented
Apr 8, 2024
| test: | ||
| expr: > | ||
| size(results) == 1 && | ||
| results[0].Object.status.containerStatuses[0].state.terminated.exitCode == 0 |
There was a problem hiding this comment.
could probably add a helper function in cel to get containerStatus
moshloop
reviewed
Apr 8, 2024
moshloop
reviewed
Apr 8, 2024
adityathebe
force-pushed
the
feat/new-kubernetes-check
branch
from
065e961
to
b376540
Compare
[skip ci]
[skip ci]
* fix how results of checks are handled in kubernetes resouce checks
adityathebe
force-pushed
the
feat/new-kubernetes-check
branch
from
b376540
to
d7b7321
Compare
adityathebe
force-pushed
the
feat/new-kubernetes-check
branch
from
d7b7321
to
31fc8a2
Compare
moshloop
reviewed
Apr 8, 2024
moshloop
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #436