feat: template resources in kubernetes resource check #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/template-kubernetes-resources
branch
from
418d856
to
28b2077
Compare
moshloop
reviewed
Apr 21, 2024
moshloop
reviewed
Apr 21, 2024
moshloop
reviewed
Apr 21, 2024
adityathebe
force-pushed
the
feat/template-kubernetes-resources
branch
2 times, most recently
from
7679209
to
2dc8ffe
Compare
move all polling and deleting tasks to use namespace and gvk. name shouldn't be used.
adityathebe
force-pushed
the
feat/template-kubernetes-resources
branch
4 times, most recently
from
4549120
to
672c94c
Compare
adityathebe
force-pushed
the
feat/template-kubernetes-resources
branch
3 times, most recently
from
118ad1d
to
c0180e9
Compare
add log line when the wait for expression fails
adityathebe
force-pushed
the
feat/template-kubernetes-resources
branch
from
c0180e9
to
8e2c1db
Compare
moshloop
reviewed
Apr 26, 2024
moshloop
reviewed
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we allow templating everything including the name of both static and non-static resources except
All polling and deleting operations, which were name based, have been moved to use the namespace + GroupVersionKind api.
If the program crashes right after it has created the kubernetes resources but before it has deleted them, then it'll just clean those resources up in the next run even if the name of the resources are randomly generated.
These labels are added to all the resources
additionally, static resources also gets