Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use json logs in chart by default #1850

Merged
merged 2 commits into from
May 20, 2024
Merged

feat: use json logs in chart by default #1850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
241f7f9
feat: use json logs in chart by default
yashmehrotra May 20, 2024
a9ea1f1
chore: set default log level to info
yashmehrotra May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion chart/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ spec:
- /app/canary-checker
args:
- operator
- {{ .Values.logLevel}}
{{- if .Values.logLevel }}
- {{ .Values.logLevel }}
{{- end }}
- --httpPort
- "8080"
- --disable-postgrest={{ .Values.disablePostgrest }}
Expand All @@ -141,6 +143,9 @@ spec:
{{- if gt (int .Values.replicas) 1 }}
- --enable-leader-election=true
{{- end }}
{{- if .Values.jsonLogs }}
- --json-logs
{{- end }}
{{- range $k, $v := .Values.extraArgs}}
- --{{$k}}={{$v}}
{{- end }}
Expand Down
5 changes: 4 additions & 1 deletion chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ grafanaDashboards: false

# Turn on pprof /debug endpoint
debug: false
logLevel: "-v"

# -v, -vv, -vvv
logLevel: ""
jsonLogs: true

# restrict canary-checker to monitor single namespace for canaries. Leave blank to monitor all namespaces
canaryNamespace: ""
Expand Down
Loading