feat: canary_check_invalid_count metric #2261
Open
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/invalid-checks
branch
3 times, most recently
from
dd299f9
to
fe82e8e
Compare
moshloop
reviewed
Oct 21, 2024
checks/http.go
Outdated
| @@ -174,7 +174,7 @@ func (c *HTTPChecker) Check(ctx *context.Context, extConfig external.Check) pkg. | |||
|
|
|||
| connection, connectionData, err := ctx.GetConnectionTemplate(check.Connection) | |||
| if err != nil { | |||
| return results.Invalidf("error getting connection %v", err) | |||
| return results.Failf("error getting connection %v", err) | |||
There was a problem hiding this comment.
hmm I guess could be both.
You could run into db timeout or kubernetes API call timeout issue.
adityathebe
force-pushed
the
feat/invalid-checks
branch
4 times, most recently
from
18e8387
to
ec6fd04
Compare
adityathebe
force-pushed
the
feat/invalid-checks
branch
from
ec6fd04
to
b836ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.