Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes-resource): handle default display template error in case of timeout #2275

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(kubernetes-resource): handle default display template error in case of timeout #2275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions checks/kubernetes_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@ func (c *KubernetesResourceChecker) Check(ctx context.Context, check v1.Kubernet
backoff = retry.WithMaxDuration(maxRetryTimeout, backoff)
}

// We do this before virtual check run in case the check times out
// and returns an err, the default templating requires 'display' in env
result.AddData(map[string]any{
"display": make(map[string]any),
})

retryErr := retry.Do(ctx, backoff, func(_ctx gocontext.Context) error {
ctx.Logger.V(4).Infof("running check: %s", virtualCanary.Name)

Expand Down
Loading