Skip to content

Commit

Permalink
chore: remove connectiondetails prefix in aws/azure
Browse files Browse the repository at this point in the history
  • Loading branch information
yashmehrotra committed Jun 5, 2024
1 parent cd541e4 commit c60abe1
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 35 deletions.
1 change: 0 additions & 1 deletion canary-checker/docusaurus.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ const config = {
favicon: 'img/canary-checker-icon.svg',
organizationName: 'flanksource',
projectName: 'canary-checker',
plugins: ['my-loaders', 'tailwind-loader'],
presets: [
[
'@docusaurus/preset-classic',
Expand Down
27 changes: 6 additions & 21 deletions canary-checker/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions canary-checker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"clsx": "^1.2.1",
"file-loader": "6.2.0",
"image-webpack-loader": "^8.1.0",
"my-loaders": "file:plugins/my-loaders",
"postcss": "8.4.25",
"postcss-import": "15.0.0",
"postcss-loader": "6.2.1",
Expand All @@ -37,7 +36,6 @@
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-markdown": "^8.0.7",
"tailwind-loader": "file:plugins/tailwind-loader",
"tailwindcss": "npm:@tailwindcss/postcss7-compat",
"url-loader": "4.1.1"
},
Expand Down
15 changes: 7 additions & 8 deletions mission-control/docs/registry/aws.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ The following table lists the configurable parameters and their default values:

| Parameter | Description | Schema | Default |
| --- | --- | --- | --- |
| `connectionDetails.connection` | AWS connection details. | [Connection](/reference/connections/aws) | "" |
| `connectionDetails.accessKey` | Name of the access key. | [EnvVar](/reference/env-var) | "" |
| `connectionDetails.secretKey` | Name of the secret key. | [EnvVar](/reference/env-var) | "" |
| `connectionDetails.region` | AWS region. | string | "" |
| `connectionDetails.endpoint` | AWS endpoint. | string | "" |
| `connectionDetails.skipTLSVerify` | Skip TLS verification.| bool | false |
| `connectionDetails.assumeRole` | Assume AWS role. | string | "" |
| `connection` | AWS connection details. | [Connection](/reference/connections/aws) | "" |
| `accessKey` | Name of the access key. | [EnvVar](/reference/env-var) | "" |
| `secretKey` | Name of the secret key. | [EnvVar](/reference/env-var) | "" |
| `regions` | AWS regions to pull from | []string | [] |
| `endpoint` | AWS endpoint. | string | "" |
| `skipTLSVerify` | Skip TLS verification.| bool | false |
| `assumeRole` | Assume AWS role. | string | "" |
| `cloudtrail.maxAge` | Maximum age for CloudTrail. | "" | |
| `cloudtrail.exclude` | List of excluded items for CloudTrail. | [] | |
| `compliance` | Enable or disable compliance. | true | |
Expand All @@ -61,7 +61,6 @@ The following table lists the configurable parameters and their default values:
| `costReporting.region` | Cost reporting region. | "" | |
| `costReporting.s3BucketPath` | S3 bucket path for cost reporting. | "" | |
| `costReporting.table` | Table for cost reporting. | "" | |
| regions | | | |
| `includeResources` | List of resources to include. | [] | |
| `excludeResources` | List of resources to exclude. | [] | |

Expand Down
6 changes: 3 additions & 3 deletions mission-control/docs/registry/azure.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ The following table lists the configurable parameters and their default values:

| Parameter | Description | Schema | Default |
| --- | --- | --- | --- |
| `connectionDetails.connection` | Azure connection details. | string | "" |
| `connectionDetails.clientID` | Azure Client ID | <CommonLink to="secrets">*EnvVar*</CommonLink> | "" |
| `connectionDetails.clientSecret` | Azure Client Secret | <CommonLink to="secrets">*EnvVar*</CommonLink> | "" |
| `connection` | Azure connection details. | string | "" |
| `clientID` | Azure Client ID | <CommonLink to="secrets">*EnvVar*</CommonLink> | "" |
| `clientSecret` | Azure Client Secret | <CommonLink to="secrets">*EnvVar*</CommonLink> | "" |

:::info
If you have setup Workload Identity Roles for Service Account, you do not have to do anything else. If you do not have that setup, you can use Client ID and Client Secret
Expand Down

0 comments on commit c60abe1

Please sign in to comment.