Merge pull request #1535 from flanksource/1512-smb-connection-form-is…

…-missing feat: add smb connection type
flanksource · Dec 7, 2023 · 11fb419 · 11fb419
2 parents 356162d + 072c64d
commit 11fb419
Showing 1 changed file with 26 additions and 23 deletions.
diff --git a/src/components/Connections/connectionTypes.tsx b/src/components/Connections/connectionTypes.tsx
@@ -793,41 +793,44 @@ export const connectionTypes: ConnectionType[] = [
     title: "SMB",
     icon: "smb",
     value: ConnectionValueType.SMB,
-    hide: true,
     fields: [
       ...commonConnectionFormFields,
       {
-        label: "Username",
-        key: "username",
-        type: ConnectionsFieldTypes.input,
-        required: true
+        label: "Server",
+        key: "server",
+        type: ConnectionsFieldTypes.GroupField,
+        groupFieldProps: {
+          fields: [
+            {
+              label: "Server",
+              key: "server",
+              type: ConnectionsFieldTypes.input,
+              required: true
+            },
+            {
+              label: "Port",
+              key: "port",
+              type: ConnectionsFieldTypes.numberInput,
+              default: 445
+            }
+          ]
+        }
       },
       {
-        label: "Password",
-        key: "password",
+        label: "Share",
+        key: "share",
         type: ConnectionsFieldTypes.input,
         required: true
       },
       {
-        label: "Workstation",
-        key: "workstation",
-        type: ConnectionsFieldTypes.input
-      },
-      {
-        label: "Share name",
-        key: "sharename",
-        type: ConnectionsFieldTypes.input
-      },
-      {
-        label: "Search path",
-        key: "searchPath",
+        label: "Username",
+        key: "username",
         type: ConnectionsFieldTypes.input
       },
       {
-        label: "Port",
-        key: "port",
-        type: ConnectionsFieldTypes.numberInput,
-        default: 445
+        label: "Password",
+        key: "password",
+        type: ConnectionsFieldTypes.EnvVarSource
       }
     ],
     convertToFormSpecificValue: (data: Record<string, any>) => {