fix: return if objects needs to be updated with finalizer

controllers/rest_controller.go

@@ -132,16 +132,7 @@ func (r *RESTReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
 			return ctrl.Result{}, err
 		}
 
-		// refresh object to avoid getting error:  the object has been modified; please apply your changes to the latest version and try again
-		if err := r.ControllerClient.Get(ctx, req.NamespacedName, rest); err != nil {
-			if kerrors.IsNotFound(err) {
-				log.Error(err, "rest not found")
-				return reconcile.Result{}, nil
-			}
-			log.Error(err, "failed to get rest")
-			incRESTFailed(name)
-			return reconcile.Result{}, err
-		}
+		return ctrl.Result{}, nil
 	}
 
 	err = tm.Update(ctx, rest)

examples/rest.yml

@@ -16,7 +16,7 @@ spec:
         "matchers": [
           {
             "name": "alertname",
-            "value": "ExcessivePodCPURatioS",
+            "value": "ExcessivePodCPURatio",
             "isRegex": false,
             "isEqual": true
           }

k8s/rest_manager.go

@@ -46,10 +46,6 @@ func (r *RESTManager) Update(ctx context.Context, rest *templatev1.REST) error {
 		return nil
 	}
 
-	if rest.Status == nil {
-		rest.Status = map[string]string{}
-	}
-
 	url := rest.Spec.Update.URL
 	method := rest.Spec.Update.Method
 	body := rest.Spec.Update.Body
@@ -82,10 +78,6 @@ func (r *RESTManager) Update(ctx context.Context, rest *templatev1.REST) error {
 }
 
 func (r *RESTManager) Delete(ctx context.Context, rest *templatev1.REST) error {
-	if rest.Status == nil {
-		rest.Status = map[string]string{}
-	}
-
 	url := rest.Spec.Remove.URL
 	method := rest.Spec.Remove.Method
 	body := rest.Spec.Remove.Body

test/e2e.go

@@ -794,6 +794,7 @@ metadata:
 spec:
   backup:
     bucket: e2e-postgres-backups
+    restic: false
   cpu: "0.5"
   memory: 6Gi
   parameters: