Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internals. Make the operator more lib-oriented #536

Merged
merged 20 commits into from
Oct 17, 2023
Merged

Refactor internals. Make the operator more lib-oriented #536

merged 20 commits into from
Oct 17, 2023

Conversation

yalosev
Copy link
Contributor

@yalosev yalosev commented Oct 6, 2023 •
edited
Loading

Overview

Refactor everything:

  • golangci-lint updated to 1.54.2
  • matrix test now have kubernetes versions 1.23-1.27
  • gopkg.in/satori/go.uuid.v1 lib changed with github.com/gofrs/uuid/v5
  • kube-client lib updated from 0.25.4 to 0.26.9
  • HookMetricsListenPort was removed
  • debug server refactored
  • unused Interfaces were removed
  • package level structured was moved to unexported
  • dump of the main queue respects output format
  • start of the api-http server was moved to the operator Start() function

What this PR does / why we need it

Hide unused structs / methods. Make the shell-operator more lib-oriented to reuse in other projects

Special notes for your reviewer

`--hook-metrics-listen-port`  was removed. HTTP handler `/metrics/hooks` integrated into base http server, configured via the `--listen-port` flag

@yalosev yalosev added the run/tests Run tests on full matrix of k8s versions label Oct 6, 2023
@github-actions github-actions bot removed the run/tests Run tests on full matrix of k8s versions label Oct 6, 2023
@yalosev yalosev added enhancement New feature or request go Pull requests that update Go code run/tests Run tests on full matrix of k8s versions labels Oct 6, 2023
@github-actions github-actions bot removed the run/tests Run tests on full matrix of k8s versions label Oct 6, 2023
@yalosev yalosev added the run/tests Run tests on full matrix of k8s versions label Oct 6, 2023
@github-actions github-actions bot removed the run/tests Run tests on full matrix of k8s versions label Oct 6, 2023
@yalosev yalosev added the run/tests Run tests on full matrix of k8s versions label Oct 6, 2023
@github-actions github-actions bot removed the run/tests Run tests on full matrix of k8s versions label Oct 6, 2023
@yalosev yalosev added the run/tests Run tests on full matrix of k8s versions label Oct 6, 2023
@github-actions github-actions bot removed the run/tests Run tests on full matrix of k8s versions label Oct 6, 2023
@yalosev yalosev added the run/tests Run tests on full matrix of k8s versions label Oct 12, 2023
@github-actions github-actions bot removed the run/tests Run tests on full matrix of k8s versions label Oct 12, 2023
@yalosev yalosev changed the title Pererafach! Refactor internals. Make the operator more lib-oriented Oct 12, 2023
@yalosev yalosev marked this pull request as ready for review October 13, 2023 11:30
@yalosev yalosev added the run/tests Run tests on full matrix of k8s versions label Oct 13, 2023
@github-actions github-actions bot removed the run/tests Run tests on full matrix of k8s versions label Oct 13, 2023
@yalosev yalosev merged commit 2af3363 into main Oct 17, 2023
17 checks passed
@yalosev yalosev deleted the refactor-cleanup-code branch October 17, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmitrykob Dmitrykob Dmitrykob approved these changes

@miklezzzz miklezzzz miklezzzz approved these changes

@libmonsoon-dev libmonsoon-dev libmonsoon-dev approved these changes

@nabokihms nabokihms Awaiting requested review from nabokihms

@diafour diafour Awaiting requested review from diafour

Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yalosev @diafour @libmonsoon-dev @miklezzzz @Dmitrykob