add IgnoreHookError patch option #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <[email protected]>
yalosev
approved these changes
Oct 13, 2023
yalosev
reviewed
Oct 13, 2023
github-actions
bot
removed
the
run/tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds additional patch_option for Filter/Patch operations named
IgnoreHookErrorand some execution logic around it.What this PR does / why we need it
If
IgnoreHookErroris set to true for a Filter/Patch operation andWithSubresourceequals to/status, such an operation will be applied even in case of the hook failure.It can come in handy in a situation when a hook operates around some kubernetes resource and one wants to make it more obvious when the resource was noticied/processed/etc by the hook last time by means of status fields.
This way we could provide some meaningful statuses or a feedback loop on what happens when a hook is executed.
Special notes for your reviewer