Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ignore lib directory while processing hooks #621

Merged
merged 4 commits into from
Jun 25, 2024
Merged

feat: Ignore lib directory while processing hooks #621

merged 4 commits into from
Jun 25, 2024

Conversation

juev
Copy link
Contributor

@juev juev commented Jun 20, 2024 •
edited
Loading

Overview

Hook spams like this:

.../hooks/lib/utils.py' is skipped: no executable permissions, chmod +x is required to run this hook"

What this PR does / why we need it

Ignore lib directory while processing hooks.
We also additionally check the files in the lib directory; if we find files with executable permissions, we display a warning.

Closes: #620

@juev juev self-assigned this Jun 20, 2024
@yalosev yalosev added enhancement New feature or request go Pull requests that update Go code labels Jun 20, 2024
@raabdullaev raabdullaev requested a review from yalosev June 20, 2024 11:20
@juev juev changed the title feat: remove warning on no executable permissions feat: Ignore lib directory while processing hooks Jun 20, 2024
@yalosev yalosev merged commit c837216 into main Jun 25, 2024
8 checks passed
@yalosev yalosev deleted the feature/620 branch June 25, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yalosev yalosev yalosev approved these changes

Assignees

@juev juev

Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore lib directory while processing hooks
2 participants
@juev @yalosev