update merics' labelset if needed #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <[email protected]>
miklezzzz
commented
Jul 10, 2024
Comment on lines
+63
to
+64
| } else if !LabelNamesEqual(collector.LabelNames(), labelNames) { | ||
| collector.UpdateLabels(labelNames) |
There was a problem hiding this comment.
not sure how to make it less noisy, maybe it makes sense to store all the collector's labels in a map alongside the slice so that it would be faster to check if any new labels are provided
Signed-off-by: Mikhail Scherba <[email protected]>
yalosev
reviewed
Jul 14, 2024
nabokihms
approved these changes
Jul 15, 2024
yalosev
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pr update the way metrics with different label sets and the same name are stored in a collector.
If a new metric has a new label, this new label is added to the collector and all previous metrics in the collector get it with an empty string as its value.
What this PR does / why we need it
Closes #616
Special notes for your reviewer