fix shell_lib regarding grouping #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <[email protected]>
miklezzzz
force-pushed
the
fix-shell_lib-group-bindings
branch
from
9899da4
to
479bd2a
Compare
yalosev
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes mapping of grouped binding contexts to
on_grouphandlers in the shell-lib.What this PR does / why we need it
Adds additional
.groupNamefield to a binding context conversion result which is used to map grouped binding contexts to aon_grouphandler.Updates shell-lib to use new
groupNamebinding context field when mapping events to handlers.Special notes for your reviewer