Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shell-operator] Fix logrus leak #674

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[shell-operator] Fix logrus leak #674

merged 1 commit into from
Oct 23, 2024

Conversation

ldmonster
Copy link
Contributor

@ldmonster ldmonster commented Oct 23, 2024 •
edited
Loading

Overview

Fixed logrus memory leak

What this PR does / why we need it

Replace logrus Writer with bytes buffer
It fixes the logrus memory leak

Special notes for your reviewer

change pipe writer for buffer
383f0b5 
Signed-off-by: Pavel Okhlopkov <[email protected]>
@ldmonster ldmonster added this to the 1.2.0 milestone Oct 23, 2024
@ldmonster ldmonster marked this pull request as ready for review October 23, 2024 11:38
@miklezzzz miklezzzz added the bug Something isn't working label Oct 23, 2024
@yalosev yalosev added the go Pull requests that update Go code label Oct 23, 2024
@yalosev yalosev removed this from the 1.2.0 milestone Oct 23, 2024
@yalosev yalosev merged commit e4f317f into main Oct 23, 2024
19 of 20 checks passed
@yalosev yalosev deleted the fix/logrus-leak branch October 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miklezzzz miklezzzz miklezzzz approved these changes

@yalosev yalosev yalosev approved these changes

Assignees

@ldmonster ldmonster

Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldmonster @yalosev @miklezzzz