fix: reset admin page save button in catch (#3963)

flarum · Sep 26, 2024 · 80e70f4 · 80e70f4
1 parent e43530e
commit 80e70f4
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/framework/core/js/src/admin/components/AdminPage.tsx b/framework/core/js/src/admin/components/AdminPage.tsx
@@ -351,6 +351,13 @@ export default abstract class AdminPage<CustomAttrs extends IPageAttrs = IPageAt
     app.alerts.show({ type: 'success' }, app.translator.trans('core.admin.settings.saved_message'));
   }
 
+  /**
+   * Called when `saveSettings` completes with errors.
+   */
+  onsavefailed(): void {
+    this.loading = false;
+  }
+
   /**
    * Returns a function that fetches the setting from the `app` global.
    */
@@ -394,6 +401,6 @@ export default abstract class AdminPage<CustomAttrs extends IPageAttrs = IPageAt
 
     this.loading = true;
 
-    return saveSettings(this.dirty()).then(this.onsaved.bind(this));
+    return saveSettings(this.dirty()).then(this.onsaved.bind(this)).catch(this.onsavefailed.bind(this));
   }
 }